HW5 is completed #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2024 22:55
agneum
approved these changes
May 23, 2024
hw05_parallel_execution/run.go
Outdated
Comment on lines
42
to
49
| for workerCount.Load() >= workerMaxCount { | ||
| time.Sleep(time.Millisecond * 10) | ||
| } | ||
|
|
||
| if errCount.Load() >= errMaxCount { // если кол-во ошибок больше допустимого | ||
| // прекращаем запускать воркеры | ||
| break | ||
| } |
There was a problem hiding this comment.
Оптимальнее и надёжнее будет запустить в работу на постоянной основе n горутин-воркеров и передавать им в работу задачи на выполнение через канал
Сейчас на каждую задачу запускается и не переиспользуется горутина. Кроме того, приходится контролировать количество воркеров
hw05_parallel_execution/run.go
Outdated
Comment on lines
111
to
116
| case <-errorCh: | ||
| errCount++ | ||
| if errCount >= m { | ||
| return ErrErrorsLimitExceeded | ||
| } | ||
| case tasksCh <- tasks[i]: |
There was a problem hiding this comment.
Подсчёт ошибок лучше вынести из цикла по задачам.
added 2 commits
May 25, 2024 05:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №5 «Параллельное исполнение»
Чек-лист студента (Что это?)
go mod tidy..syncфайл. Зачем его удалять?Критерии оценки
Зачёт от 7 баллов