Hw09 struct validator #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d edit rulesRules map
agneum
approved these changes
Dec 18, 2024
| var ( | ||
| // целое не может быть меньше условия. | ||
| ErrIntCantBeLess = errors.New("cannot be less") | ||
| // целое не содержит совпадений с регулярным выражением. |
There was a problem hiding this comment.
Комментарий не совпадает с содержимым переменной
|
|
||
| func (v ValidationErrors) Error() string { | ||
| cnt := len(v) | ||
| if cnt < 1 { | ||
| return "" | ||
| } | ||
| return fmt.Sprintf("%d structure validation errors found", cnt) | ||
|
|
||
| return func() string { |
There was a problem hiding this comment.
Не понинаю, для чего обернуто в дополнительную функцию
Comment on lines
+37
to
+50
| "len": func(v reflect.Value, condition string) error { | ||
| c, err := strconv.Atoi(condition) | ||
| if err != nil { | ||
| // 'condition' недопустимое условие для правила 'len'. | ||
| return fmt.Errorf("'%s' %w '%s'", condition, ErrInvalidCond, "len") | ||
| } | ||
|
|
||
| if utf8.RuneCountInString(v.String()) != c { | ||
| return ValidationError{ | ||
| Err: fmt.Errorf("%w %s", ErrStrLenNotEqual, condition), | ||
| } | ||
| } | ||
| return nil | ||
| }, |
There was a problem hiding this comment.
Можно выделить в самостоятельные функции, чтобы удобнее читать мапу с набором доступных валидаторов
There was a problem hiding this comment.
Это решение сознательное. Чтобы по типу и правилу сразу увидеть функцию-валидатор.
hw09_struct_validator/validator.go
Outdated
Comment on lines
95
to
97
| if nested { | ||
| return validateStructF(fieldValue, rules) | ||
| } |
There was a problem hiding this comment.
Можно перенести в цикл и убрать переменную nested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание №9 «Валидатор структур»
Чек-лист студента (Что это?)
go mod tidy..syncфайл. Зачем его удалять?Критерии оценки
Зачёт от 7 баллов