Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - support for nested folders #195

Conversation

DineshSolanki
Copy link
Owner

Implements feature of searching nested folder in poster process mode, this is specially helpfull when you have various collection folders with different media titles in them. closes #192

…s for the case of different parts of a movie collection

Known issue - Parent folder is not processed
Implement parameterized CloseDialog method to incorporate skipAll logic, and remove GlobalVariables.SkipAll flag usage. Dialog skipping now relies on a passed parameter rather than a global variable, this would help in skipping only the subfolders of parent only in case of nested folders, and also is a step toward eliminating global variables.
Added text and translations to skip all remaining titles for a specific parent directory (part of feature #192). The SkipAllText property is now dynamically set based on the parent folder name in the SearchResultViewModel.
Replaced custom logic in GetAllSubFolders with a single call to Directory.GetDirectories, which improves performance and readability.
@DineshSolanki DineshSolanki self-assigned this Mar 21, 2024
@DineshSolanki DineshSolanki added the enhancement New feature or request label Mar 21, 2024
Explicitly added curly braces for single-statement control structures to improve code readability and maintainability, aligning with coding best practices and preventing potential errors during future modifications.
@DineshSolanki DineshSolanki merged commit ab9545c into master Mar 21, 2024
3 checks passed
@DineshSolanki DineshSolanki deleted the 192-support-for-nested-subfolder-such-as-moviesstarwars-collectionstar-wars-1 branch March 21, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for nested subfolder such as Movies/StarWars collection/Star Wars 1
1 participant