performance refactoring - use native call for file existence, use parallel async, refactor for maintainability #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the icon creation faster and the code more maintainable Refactored the ` MakeIco ` method to support async execution and parallelism. Introduced `IconProperties` to encapsulate icon data and updated `BuildFolderIco` to use the new class. Adjusted icon overlay handling to improve code maintainability and performance.
Refactored occurrences of File.Exists to use the new FileUtils.FileExists method. This change centralizes the file existence check, making the codebase more maintainable and consistent as we are testing out p/invoke method to check existence for performance
Converted methods to async to improve performance by allowing tasks to run concurrently. Updated `RefreshIconCache` and `DeleteIconsFromSubfolders` to use asynchronous counterparts.
Refactor to use predefined window render size. The render size is now a static readonly property, ensuring it's not being created for each instance.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.