-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Updated logic to resolve out_dir paths relative to workspace #3393
Conversation
The code looks reasonable to me. Is it based on what was present in 0.5? |
No, I noticed the issue, thought of a solution, and then tried implementing it to fix the problem. |
All good, I was just curious how it ended up being lost in the new version. Is it possible to add a unit test for this functionality? |
Yes! |
We dropped To properly isolate builds from each other, dx needs to be somewhat opaque with its output structure. You can use Given how many folks rely on
|
I encountered this issue while following the instructions in the Dioxus Cookbook for publishing a website on GitHub Pages. The corresponding entry should also be updated based on the decision made regarding |
I'm going to combine this with the #3572 PR to copy I don't want us to expose the internals of the dioxus build directories since it's very hard to keep those "clean." We have a similar problem to Cargo's |
Implemented this in #3572 - you should've gotten co-author creds. Thank you! |
This fix ensures the out_dir configuration in Dioxus.toml is respected for web builds, allowing users to specify custom output directories. Key updates include:
Users can now customize the build output directory seamlessly.