-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: application subscriptions #1113
Conversation
Would you be able to provide/add an example to this pull request show casing how an end user would be able to utilize this functionality to mark a slash command as requiring premium? I can see it being quite a regular thing coming up in the future so the clarity would be nice |
good point, thanks! Added in 989327a. |
c80dbe2
to
4b66b52
Compare
Removed the SKU/entitlement HTTP endpoints in 4b66b52 due to https://github.com/discord/discord-api-docs/pull/6502/files#diff-39e6aeaafba5726f3fb409da21a6953dfb679480f09038a0d05f4dd93e89e074R11 :/ edit: reverted the revert again, as the linked changes were decided against. |
…eduled for removal" This reverts commit 4b66b52.
Please merge this 🙏🙏🙏 |
🚀 LFG i’m a god |
Summary
discord/discord-api-docs@b97fad3 (+ discord/discord-api-docs@b8feadd)
Since this feature is US-only, I'm unable to test most of it; still working on that part.Tested all implemented functionality now.Nevertheless, all documented functionality is implemented. The
SKU
/Entitlement
models have been tested using the example structs provided by the docs, but that's really it.There are a few
TODO
s scattered across the code regarding testing and naming some things; feedback for those would be appreciated. The api docs are lacking in a few aspects (gateway events, in particular, are somewhat of a guessing game), but most of it is fairly straightforward.Checklist
pdm lint
pdm pyright