Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Add overloads for application command create and edit methods. #1151

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

elenakrittik
Copy link
Contributor

Summary

Adds overloads to Client.[create|edit]_[guild|global]_command() methods to make typing for them more precise.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@elenakrittik elenakrittik changed the title typing(client): Add overloads for application command create and edit methods. refactor(client): Add overloads for application command create and edit methods. Jan 14, 2024
@elenakrittik elenakrittik marked this pull request as ready for review January 14, 2024 18:01
@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Jan 14, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jan 14, 2024
@shiftinv shiftinv self-requested a review January 14, 2024 23:06
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit d782f54 into DisnakeDev:master Jan 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: enhancement New feature t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants