Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add raw equivalent of on_presence_update - on_raw_presence_update. #1154

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

elenakrittik
Copy link
Contributor

@elenakrittik elenakrittik commented Jan 17, 2024

Summary

Resolves #1152

This is (apparently) the first time i am working with raw events, so i may have made some serious mistakes. I tried my best to follow how other existing raw events work (and from my quick tests everything works fine), but please correct me if i did something wrong.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@elenakrittik elenakrittik marked this pull request as ready for review January 17, 2024 18:43
@shiftinv shiftinv added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Jan 18, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jan 18, 2024
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you add the new event to the description of Intents.presences?

These comments are mainly related to documentation - I'm still not fully decided on which fields to deserialize into the raw event, but this already looks pretty good.

disnake/raw_models.py Outdated Show resolved Hide resolved
docs/api/events.rst Outdated Show resolved Hide resolved
docs/api/members.rst Outdated Show resolved Hide resolved
docs/api/events.rst Outdated Show resolved Hide resolved
docs/api/events.rst Outdated Show resolved Hide resolved
docs/api/members.rst Show resolved Hide resolved
elenakrittik and others added 4 commits February 2, 2024 16:14
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: lena <77104725+elenakrittik@users.noreply.github.com>
elenakrittik and others added 3 commits February 13, 2024 19:50
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: lena <77104725+elenakrittik@users.noreply.github.com>
@shiftinv shiftinv merged commit a74e672 into DisnakeDev:master Feb 13, 2024
27 checks passed
@elenakrittik elenakrittik deleted the feat/raw-presence-updated branch February 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add on_raw_presence_update event
2 participants