-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add raw equivalent of on_presence_update
- on_raw_presence_update
.
#1154
Merged
shiftinv
merged 9 commits into
DisnakeDev:master
from
elenakrittik:feat/raw-presence-updated
Feb 13, 2024
Merged
feat: Add raw equivalent of on_presence_update
- on_raw_presence_update
.
#1154
shiftinv
merged 9 commits into
DisnakeDev:master
from
elenakrittik:feat/raw-presence-updated
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
t: enhancement
New feature
s: needs review
Issue/PR is awaiting reviews
labels
Jan 18, 2024
shiftinv
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you add the new event to the description of Intents.presences
?
These comments are mainly related to documentation - I'm still not fully decided on which fields to deserialize into the raw event, but this already looks pretty good.
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: lena <77104725+elenakrittik@users.noreply.github.com>
shiftinv
reviewed
Feb 13, 2024
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: lena <77104725+elenakrittik@users.noreply.github.com>
shiftinv
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1152
This is (apparently) the first time i am working with raw events, so i may have made some serious mistakes. I tried my best to follow how other existing raw events work (and from my quick tests everything works fine), but please correct me if i did something wrong.
Checklist
pdm lint
pdm pyright