Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOV-4463: BOB Gateway example integration #1022

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

SOV-4463: BOB Gateway example integration #1022

wants to merge 17 commits into from

Conversation

rick23p
Copy link
Collaborator

@rick23p rick23p commented Oct 8, 2024 •
edited
Loading

@rick23p rick23p added the enhancement New feature or request label Oct 8, 2024
@rick23p rick23p self-assigned this Oct 8, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: edc52f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for sovryn-dapp ready!

Name Link
🔨 Latest commit edc52f9
🔍 Latest deploy log https://app.netlify.com/sites/sovryn-dapp/deploys/6798b5d22366330008c81e4e
😎 Deploy Preview https://deploy-preview-1022.preview.sovryns.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for sovryn-storybook canceled.

Name Link
🔨 Latest commit edc52f9
🔍 Latest deploy log https://app.netlify.com/sites/sovryn-storybook/deploys/6798b5d28ea11c0008b4853b

@rick23p rick23p changed the title Feat/bob gateway SOV-4463: BOB Gateway example integration Oct 8, 2024
@rick23p rick23p added the do-not-merge PR should not be merged due to dependencies/blockers label Oct 8, 2024
@tiltom tiltom self-requested a review October 9, 2024 11:57
@Rickk137 Rickk137 marked this pull request as ready for review October 9, 2024 12:41
@rick23p rick23p requested review from pietro-maximoff and removed request for tiltom January 7, 2025 10:37
pietro-maximoff
pietro-maximoff requested changes Jan 7, 2025
View reviewed changes
apps/frontend/src/app/5_pages/BobGateway/BobGateway.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayWithdraw/BobGatewayWithdraw.tsx Outdated Show resolved Hide resolved
...ngPage/components/BobDepositModal/components/PriceRange/components/AmountForm/AmountForm.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/hooks/useSendGatewayTransaction.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/hooks/useSendGatewayTransaction.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/hooks/useSendGatewayTransaction.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayDeposit/BobGatewayDeposit.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayDeposit/BobGatewayDeposit.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayDeposit/BobGatewayDeposit.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayForm/BobGatewayForm.tsx Outdated Show resolved Hide resolved
pietro-maximoff
pietro-maximoff approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@pietro-maximoff pietro-maximoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rick23p approved with a couple of minor comments

apps/frontend/src/app/5_pages/BobGateway/components/BobGatewayDeposit/BobGatewayDeposit.tsx Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BitcoinWallet/BitcoinWallet.utils.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/5_pages/BobGateway/components/BitcoinWallet/BitcoinWallet.utils.ts Outdated Show resolved Hide resolved
@tiltom tiltom added this to the v1.1.28 milestone Jan 21, 2025
@creed-victor creed-victor removed this from the v1.1.28 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietro-maximoff pietro-maximoff pietro-maximoff approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@rick23p rick23p

Labels
do-not-merge PR should not be merged due to dependencies/blockers enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rick23p @pietro-maximoff @tiltom @creed-victor