Quality of Life Improvements #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- made a shell script: download_clang_format_binaries to grab the bins from the upstream repo. No need to manually commit then all the time. - added a versions.txt file that maps short names to latest long name. For example 18==18.1.8. - delete the bins added to this repo. It makes for a large repo to clown down. Plus this should in theory speed up execution time of the action. - make a blank.txt inside the clang-format folder.
- added a maintain markdown file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Key Changes:
download_clang_format_binaries.shwhich automated the downloading of binary filesmaintain.mdto document how the files thatdownload_clang_format_binaries.shrelies on must be maintainedTesting:
I did basic testing of the
download_clang_format_binaries.shscript. I tried the following options:./download_clang_format_binaries.sh 19./download_clang_format_binaries.sh 18./download_clang_format_binaries.sh 10I wasn't sure how to test the
action.yml.More Thoughts:
This is a big change in terms of how things were done in the past. Perhaps this can be a new major version.
v1.0.0. But with a few beta releases first likev1.0.0b1or something like that.