i#3699: Add more checks to is_aflags_{spill,restore} in drreg.c. #7178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ARM/AArch64 not all MRS/MSR instructions operate on aflags, and on ARM the register source operand of MSR, if there is one, is the second operand. This change made the test sample.memval_simple pass on 32-bit ARM. Issue: #3699 Change-Id: I9a04273ed0507c0f8cccd636fdbc0aff1b5bf36d
abhinav92003
approved these changes
Jan 9, 2025
Change-Id: Iea375f69bee6acbc33ef0e90d5e5c892942082d4
Change-Id: Iff905ee5e483bbc7a9f174ce085be81bbb203965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ARM/AArch64 not all MRS/MSR instructions operate on aflags, and on ARM the register source operand of MSR, if there is one, is the second operand.
This change made the test sample.memval_simple pass on 32-bit ARM. (But client.drreg-test does not yet pass.)
Issue: #3699