Fix galaxy.yaml #56
Closed
Fix galaxy.yaml #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubrak
force-pushed
the
fix-license-in0galaxy.yaml
branch
from
36d5e26 to
1faa556
Compare
WStechura
approved these changes
Dec 12, 2024
jakubrak
force-pushed
the
fix-license-in0galaxy.yaml
branch
3 times, most recently
from
567db21 to
ba1ba91
Compare
WStechura
force-pushed
the
fix-license-in0galaxy.yaml
branch
3 times, most recently
from
f8a8abd to
a00f64a
Compare
WStechura
force-pushed
the
fix-license-in0galaxy.yaml
branch
from
7dab871 to
bab88ea
Compare
karczex
suggested changes
Dec 20, 2024
roles/oneagent/tests/conftest.py
Outdated
| @@ -42,7 +42,7 @@ | |||
|
|
|||
|
|
|||
| def is_local_deployment(platforms: PlatformCollection) -> bool: | |||
| return any("localhost" in hosts for _, hosts in platforms.items()) | |||
| return any("localhost" in hosts for platform, hosts in platforms.items()) | |||
There was a problem hiding this comment.
i don't like this ;) Isn't pep8 checker throwing error on this?
roles/oneagent/tests/conftest.py
Outdated
| @@ -54,7 +54,7 @@ def parse_platforms_from_options( | |||
| if key in deployment_platforms and hosts: | |||
| if "localhost" in hosts: | |||
| logging.info( | |||
| f"Local deployment detected for {key}, only this host will be used") | |||
| "Local deployment detected for %s, only this host will be used", key) | |||
There was a problem hiding this comment.
this is wrong, F-strings are much better sine python3.7. Maybe something went wrong with pytlint settings
| @@ -18,13 +18,17 @@ saveToConfig() { | |||
| while [ $# -gt 0 ]; do | |||
| # example command: --set-host-property=TENANT=tenant1 | |||
| # setter: --set-host-property | |||
| local setter="$(cutVariable "${1}" "=" 1)" | |||
| local setter | |||
karczex
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.