Add del2 and del4 terms to manufactured solution test #6862
Conversation
Co-authored-by: Hyun (Hyun-Gyu) Kang <47987430+hyungyukang@users.noreply.github.com>
cbegeman
added
BFB
|
Further discussion and review is located at E3SM-Ocean-Discussion#110 |
There was a problem hiding this comment.
@cbegeman, thank you for adding this. The code looks good.
I successfully ran manufactured_solution/convergence_both/del2 and manufactured_solution/convergence_both/del4 tests in Polaris ( E3SM-Project/polaris#234) using MPAS-Ocean from this PR on Frontier with the GNU compiler. As expected, second-order convergence was achieved for both the del2 and del4 tests.
- del2 test:
- del4 test:
There was a problem hiding this comment.
Approved based on testing for E3SM-Project/polaris#234. Thanks for this @cbegeman!
|
@sbrus89 and @hyungyukang Thank you so much for your review and testing! For posterity, this is the updated difference plot for del4. It is similar for del2. |
#6862) Add del2 and del4 terms to manufactured solution test This feature is used only for MPAS-Ocean standalone testing of the horizontal mixing operators del2 and del4. It is an extension of the existing manufactured solution test case. When either or both of del2 and del4 momentum terms are included in the dynamics, we add the corresponding source terms to the manufactured solution at runtime. [BFB] not used by E3SM
|
Passes:
merged to next |
|
Thanks, @jonbob! |
|
merged to master |
This feature is used only for MPAS-Ocean standalone testing of the horizontal mixing operators del2 and del4. It is an extension of the existing manufactured solution test case. When either or both of del2 and del4 momentum terms are included in the dynamics, we add the corresponding source terms to the manufactured solution at runtime.
[BFB]