Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tridiagonal solver design document #166

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mwarusz
Copy link
Member

@mwarusz mwarusz commented Nov 21, 2024

Checklist

  • Documentation:
    • Design document has been generated and added to the docs
    • User's Guide has been updated
    • Developer's Guide has been updated
    • Documentation has been built locally and changes look as expected
  • Testing
    • A comment in the PR documents testing used to verify the changes including any tests that are added/modified/impacted.
    • CTest unit tests for new features have been added per the approved design.
    • Polaris tests for new features have been added per the approved design (and included in a test suite)
    • Unit tests have passed. Please provide a relevant CDash build entry for verification.
    • Polaris test suite has passed
    • Performance related PRs: Please include a relevant PACE experiment link documenting performance before and after.
  • Stealth Features
    • If any stealth features are included in the PR, please confirm that they have been documented.

@mark-petersen mark-petersen self-requested a review December 9, 2024 16:31
@cbegeman
Copy link

Note that this design doc includes the Schopf and Loughe (1995) approach for accuracy and stability discussed here: E3SM-Ocean-Discussion#42

@mwarusz mwarusz force-pushed the mwarusz/omega-tridiagonal-design branch from d519042 to 342bb32 Compare January 23, 2025 21:41
@mwarusz mwarusz mentioned this pull request Jan 24, 2025
8 tasks
@mwarusz mwarusz marked this pull request as ready for review January 24, 2025 16:13
@mwarusz
Copy link
Member Author

mwarusz commented Jan 24, 2025

@mark-petersen

I have updated this design doc and it is now ready for review. I also opened a draft PR with the implementation (#194). When reviewing the design it might be helpful for you to have a look at one of the unit tests showing how these solvers are used to solve a simple 1D diffusion problem:

https://github.com/mwarusz/E3SM/blob/5617516be139facfaa904e0713287a0d9e4d5b8f/components/omega/test/base/TridiagonalTest.cpp#L146-L245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants