Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on InitialState stream in Default.yml #180

Merged

Conversation

xylar
Copy link

@xylar xylar commented Dec 5, 2024

I ran into confusion where I tried to change Freq instead of FreqUnits on restart. In the process of fixing the comment for that issue, I decided to tinker a bit more.

@xylar xylar added the clean up label Dec 5, 2024
@xylar xylar requested a review from philipwjones December 5, 2024 22:01
@xylar xylar self-assigned this Dec 5, 2024
Comment on lines -37 to +39
# InitialState should only be used when starting from scratch
# After the simulations initial start, the frequency should be
# changed to never so that the initial state file is not read.
# InitialState should only be used when starting from scratch.
# For restart runs, the frequency units should be changed from
# "OnStartup" to "never" so that the initial state file is not read.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from "frequency" to "frequency units" is the only important thing here. The rest are just suggestions.

@xylar xylar assigned philipwjones and unassigned xylar Dec 5, 2024
Copy link

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. This is more correct/clear.

@philipwjones philipwjones merged commit e4589a9 into E3SM-Project:develop Dec 5, 2024
2 checks passed
@xylar xylar deleted the omega/fix-comment-in-default-yaml branch December 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants