Fix segfault and other issues in time stepper test #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues in the time stepper test:
NVertLevels
needs to be reset to 1.Unfortunately, fixing these issues does not fix the segfault on pm-gpu with gnugpu. It appears that this segfault is caused by a compiler bug. The final commit in this PR is a workaround, which fixes the segfault by removing error codes from the halo pack and unpack functions. I think this is acceptable, because there wasn't any error handling in those functions.
Checklist
Aside from #183, every test is passing on pm-gpu.