Adds design document for Omega driver layer #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrus89
reviewed
Feb 5, 2024
There was a problem hiding this comment.
@philipwjones, This looks good to me. I don't have any substantial suggestions, since it seems to cover all the bases. I just made a couple comments on things I thought of as I read through.
changes in response to reviewer comments
sbrus89
approved these changes
Feb 6, 2024
mark-petersen
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
This all makes sense. Basically, we are requiring init, run, and finalize methods, and allowing the model to be run in both standalone and coupled modes. Like MPAS-Ocean, the coupled and standalone modes should be run with identical forcing variables. Unlike MPAS-Ocean, there will be no run mode for analysis without forward time steps (MPAS Analysis mode) or for creating initial conditions (MPAS init mode).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new design document for the top driver layer(s) in Omega. The specifics of argument lists will change during implementation and the actual E3SM coupler interfaces will be added when we get closer to E3SM integration.
Checklist