Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit autoupdate workflow #212

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Dec 3, 2024

This adds a GitHub actions workflow that will run the pre-commit autoupdate command to update pre-commit and its dependencies. The workflow is set to run weekly on Wednesdays.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added the ci Changes affect github actions CI label Dec 3, 2024
@altheaden
Copy link
Collaborator Author

Testing

I tested this workflow on my fork and it worked as expected when set to run when the main branch was pushed to. I haven't tested the weekly schedule, since that requires waiting until it runs, so that will have to wait.

@altheaden
Copy link
Collaborator Author

@xylar Can you tell me if you see anything obvious that should be changed about this workflow?

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, do Push Changes and Make PR not get called if there are no changes? Or do they fail? If the latter, that might be confusing especially since there's no text to say that there were no changes.

@xylar
Copy link
Collaborator

xylar commented Dec 3, 2024

Very nice work, by the way! I'm looking forward to seeing this in action!

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks superb!

@xylar xylar merged commit bd09ad8 into E3SM-Project:main Dec 3, 2024
6 checks passed
@xylar xylar deleted the auto-update-action branch December 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants