Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set config.filepath after loading new config options #138

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 17, 2023

Before this merge, we were not setting a config's filepath attribute after loading the config options from a file. This causes the step to fail for cryptic reasons if it is rerun later as part of a test suite (because it failed the first time).

Checklist

  • Testing comment in the PR documents testing used to verify the changes

Before this merge, we were not setting a config's `filepath`
attribute after loading the config options from a file.  This
causes the step to fail for cryptic reasons if it is rerun later
as part of a test suite (because it failed the first time).
@xylar xylar added bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis labels Oct 17, 2023
@xylar xylar self-assigned this Oct 17, 2023
@xylar
Copy link
Collaborator Author

xylar commented Oct 17, 2023

Testing

When I run a custom suite with:

  ocean/spherical/icos/geostrophic
  ocean/spherical/icos/geostrophic/with_viz

and with the convergence tolerance set to 2.0 (so analysis fails), I see the expected failures with this branch, whereas for a similar test with #104, I was seeing:

Traceback (most recent call last):
  File "/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/ocn-port-sphere-transport/polaris/run/serial.py", line 326, in _log_and_run_task
    baselines_passed = _run_task(task, available_resources)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/ocn-port-sphere-transport/polaris/run/serial.py", line 399, in _run_task
    config_filename = os.path.join(step.base_work_dir,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 90, in join
  File "<frozen genericpath>", line 152, in _check_arg_types
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

@xylar xylar merged commit ac187a8 into E3SM-Project:main Oct 17, 2023
@xylar xylar deleted the fix-config-filepath branch October 17, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant