Port changes to grid_1d package from Compass
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge also breaks out functions related to `tanh_dz` into their own module.
xylar
force-pushed
the
port-grid-1d-changes
branch
from
7b5a0aa to
c78288d
Compare
cbegeman
approved these changes
Nov 1, 2023
|
@cbegeman, thanks so much for testing! I hadn't had a chance yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge brings over clean-up and enhancements from MPAS-Dev/compass#581. This includes renaming functions specific to
tanhlayer thickness for clarity, adding support for theindex_tanh_dzvertical grid, and adding missingjsonfiles that define E3SMv1 vertical coordinates.Checklist
Testingcomment in the PR documents testing used to verify the changes