Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit updates and fixes #258

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

altheaden
Copy link
Collaborator

@altheaden altheaden commented Jan 7, 2025

This PR makes a few changes to the pre-commit configuration file and the pre-commit steps in the build CI workflow. I also did some minor cleanup to the build workflow.
Changes:

  1. Added an argument to the build workflow python version matrix to not cancel other jobs when a job fails for a specific python version.
  2. Added a check that locates the files with changes and runs pre-commit only on those files.
  3. Updated pre-commit by running pre-commit autoupdate
  4. Cleaned up an unnecessary comment in the build workflow.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, these changes look great and are much appreciated!

@xylar xylar self-assigned this Jan 7, 2025
@xylar xylar added the ci Changes affect github actions CI label Jan 7, 2025
@xylar
Copy link
Collaborator

xylar commented Jan 7, 2025

I'm pretty sure the failed test was just a glitch. But it was a good test that it didn't cancel the other jobs! So what luck that we had a crash :-)

@xylar xylar merged commit 48e8418 into E3SM-Project:main Jan 7, 2025
5 checks passed
@xylar xylar deleted the pre-commit-changed-files branch January 7, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants