Test wildcards #98
Open
Test wildcards #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsyth2
commented
Oct 1, 2020
| @@ -148,6 +187,9 @@ def testExtractKeepHPSS(self): | |||
| def testExtractCache(self): | |||
| self.helperExtractCache('testExtractCache', 'none') | |||
|
|
|||
| def testExtractWildcard(self): | |||
There was a problem hiding this comment.
Do we need a test with HPSS too?
| print(output + err) | ||
| expected_present = ['Extracting ab2.txt', 'Extracting ab3.txt'] | ||
| self.check_strings(cmd, output + err, expected_present, []) | ||
| cmd = '{}zstash extract --hpss={} a*'.format(zstash_path, self.hpss_path) |
There was a problem hiding this comment.
Interestingly, adding double quotes seems to cause a failure and not adding them allows the tests to pass -- the reverse of our experience as users. I believe this is because subprocess.Popen requires cmd to be converted to a list and I imagine the conversion encapsulates a* in quotes. Not sure if there's a way to automate a test in such a way as to use the quotes.
There was a problem hiding this comment.
Try using shell=True? If that doesn't work, perhaps we should just close #96 without adding automated testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for wildcards, specifically the scenario presented in #96.