Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A start to modify docs for eessi_mixin #340

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

casparvl
Copy link
Collaborator

No description provided.

@casparvl casparvl marked this pull request as ready for review November 12, 2024 16:06
@casparvl casparvl changed the title A start to modify docs for eessi_mixin (WIP) A start to modify docs for eessi_mixin Nov 12, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice already!

mostly small things + suggested text for the CI tag

docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Outdated Show resolved Hide resolved
docs/test-suite/writing-portable-tests.md Show resolved Hide resolved
casparvl and others added 3 commits November 19, 2024 12:41
Implemented many good textual improvements from the code review.

Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
@casparvl casparvl requested a review from smoors November 19, 2024 11:48
Caspar van Leeuwen added 2 commits November 20, 2024 15:35
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic work, thank you @casparvl !!!

@bedroge bedroge merged commit 0779165 into EESSI:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants