-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A start to modify docs for eessi_mixin #340
Merged
bedroge
merged 15 commits into
EESSI:main
from
casparvl:adapt_test_suite_tutorial_for_eessi_mixin
Nov 20, 2024
Merged
A start to modify docs for eessi_mixin #340
bedroge
merged 15 commits into
EESSI:main
from
casparvl:adapt_test_suite_tutorial_for_eessi_mixin
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casparvl
changed the title
A start to modify docs for eessi_mixin (WIP)
A start to modify docs for eessi_mixin
Nov 12, 2024
smoors
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very nice already!
mostly small things + suggested text for the CI tag
Implemented many good textual improvements from the code review. Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
…a certain phase, and put the 'in' option between brackets
smoors
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic work, thank you @casparvl !!!
bedroge
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.