Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IKEA E1524/E1810) Improve Blueprint adding Z2M 2.0 MQTT Device Trigger support #662

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fleskalebas
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Using #661 as a base, I created a PR for supporting the E1524/E1810 remote with additional buttons to make my remote compatible again with the latest Z2M update.

The main difference is that I choose to add a 'Legacy Zigbee2MQTT' option in the select, making it easier to refer to the correct chosen integration later in the blueprint.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Hey @fleskalebas, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@LelouBil
Copy link

There are indentation issues in the triggers block

@fleskalebas fleskalebas force-pushed the ikea_e1524_e1810 branch 3 times, most recently from 5269c5d to 0436455 Compare January 10, 2025 20:53
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Hey @fleskalebas,

✅ Your contribution passed all the checks, awesome!
A maintainer will soon review your submission and provide additional feedback regarding your changes.

Thanks again for dedicating your precious time to this project. 🔥

📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links.

https://github.com/fleskalebas/awesome-ha-blueprints/blob/ikea_e1524_e1810/blueprints/controllers/ikea_e1524_e1810/ikea_e1524_e1810.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants