Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_3_108: Ocean emissions fix #795

Merged
merged 30 commits into from
Apr 27, 2023
Merged

cam6_3_108: Ocean emissions fix #795

merged 30 commits into from
Apr 27, 2023

Conversation

fvitt
Copy link

@fvitt fvitt commented Apr 24, 2023 •
edited
Loading

Fix issue with ocean emissions in B compsets where SSTs are zero over land.

fixes #794
closes #567
closes #747

fvitt added 19 commits February 1, 2023 11:42
@fvitt
pass lightning flash frequency to mediator for CTSM
b66dd91 
        modified:   Externals.cfg
        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
Improve cld-to-grnd lightning documentation; change "atm_lightning_fl…
6a89a31 
…ash_freq" to "atm_provides_lightning"; minor cleanup

        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
Fix restart issue -- use pbuf field for flash freq field
fde2a59 
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
Check namelist setting of atm_provides_lightning
9f0650e 
        modified:   bld/build-namelist
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
calc lightning only when cam phys is used
8566caa 
        modified:   bld/build-namelist
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
apply namelist scaling factor to flash freq
4afeaae 
        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/control/runtime_opts.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
code clean up
1481f61 
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
corrections for later cmeps
047793b 
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
        modified:   src/physics/cam_dev/physpkg.F90
@fvitt
atm_provides_lightning is FALSE if simple phys or aquaplanet
db9bb12 
	modified:   bld/build-namelist
	modified:   src/control/camsrfexch.F90
@fvitt
remove factor from cld2grnd flash freq; fix typos
39d1c7d 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
Minor changes to history fld units
723f1cd 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
restore factor setting
75ba203 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
add LGHTNG_CLD2GRND diag
2eb1ca0 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
correct calc_nox_prod logic; misc clean up
5e75733 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
minor cleanup
62edc57
@fvitt
revert setting of lght_no_prd_factor
f75b772 
        modified:   bld/build-namelist
@fvitt
move setting of namelist options from "Write output files" section
3812ed5 
        modified:   bld/build-namelist
@fvitt
merge to head of ESCOMP/cam_development
a2a505b
@fvitt
loop over columns rather than use where block; specify intent for arg…
4e7d685 
…uments

	modified:   src/chemistry/mozart/ocean_emis.F90
@fvitt fvitt added the bug-fix This PR was created to fix a specific bug. label Apr 24, 2023
@fvitt fvitt added this to the CAM6.5 milestone Apr 24, 2023
@fvitt fvitt self-assigned this Apr 24, 2023
@fvitt fvitt marked this pull request as ready for review April 24, 2023 14:59
@fvitt fvitt changed the title Ocean emission fix Ocean emissions fix Apr 24, 2023
fvitt added 2 commits April 24, 2023 09:59
@fvitt
use ESCOMP/CMEPS tag
f236f1d 
	modified:   Externals.cfg
@fvitt
Jesse's change requests
af5d2b6 
	modified:   src/chemistry/mozart/mo_lightning.F90
	modified:   src/control/camsrfexch.F90
cacraigucar
cacraigucar reviewed Apr 24, 2023
View reviewed changes
src/chemistry/mozart/ocean_emis.F90
Comment on lines +246 to +248
where(salinity < 0._r8)
salinity = 33.0_r8
end where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally naive comment - It feels like this is a very large number to set salinity to when I assume that salinity could also be 0.001 and not be reset. I would have expected that salinity would be reset to a very small positive number if it was less than zero. Is there the potential for this to lead to a high gradient between two adjacent columns?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't know. This was moved from line 475. I am preserving bit-for-bit answers here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvitt - Doing a "blame", line 475 was something you brought in along with Siyaun Wang back in April 2020. Could you please reach out to Siyaun and check whether this is something which should be changed, and if so, please open an issue. I will approve this PR "as-is" to preserve answers for this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quick explanation from Siyaun:
"In general 33 is a very typical ballpark value for salinity, and overall the air-sea exchange process is not really sensitive to salinity, and that's why I'm using climatology for modern-day simulations. There might be a few grids with bad salinity values but are good in other regards and I wanted to save those grids."

So I don't think we should change it. It is filling in missing values with a typical value of 33.

cacraigucar
cacraigucar approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a caveat that the salinity value for when salinity is less than zero might need to be changed in a future update.

@cacraigucar cacraigucar changed the title Ocean emissions fix cam6_3_108: Ocean emissions fix Apr 24, 2023
@fvitt fvitt merged commit 5e11806 into ESCOMP:cam_development Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume nusbaume approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

@jedwards4b jedwards4b jedwards4b approved these changes

Assignees

@fvitt fvitt

Labels
bug-fix This PR was created to fix a specific bug.
Projects
CAM Development
Status: Tag
Milestone
CAM6.5
Development

Successfully merging this pull request may close these issues.
4 participants
@fvitt @jedwards4b @cacraigucar @nusbaume