Cloud-to-ground lightning flash frequency coupling #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
modified: cime_config/namelist_definition_drv_flds.xml
modified: mediator/esmFldsExchange_cesm_mod.F90
modified: mediator/fd_cesm.yaml
modified: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
modified: cime_config/namelist_definition_drv_flds.xml
modified: cime_config/namelist_definition_drv_flds.xml
modified: mediator/esmFldsExchange_cesm_mod.F90
modified: mediator/fd_cesm.yaml
…14.18_lightning_coupling
jedwards4b
requested changes
Apr 6, 2023
| end if | ||
| call shr_log_getLogUnit(s_logunit) | ||
| call ESMF_VMGetCurrent(vm, rc=rc) | ||
| if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return |
There was a problem hiding this comment.
Please change these to use the helper routine
if (chkerr(rc,LINE,u_FILE_u)) return
There was a problem hiding this comment.
It's in: use nuopc_shr_methods, only : chkerr
| ! ------------------------------------------------------------------------ | ||
| ! Broadcast values to all processors | ||
| ! ------------------------------------------------------------------------ | ||
| call shr_mpi_bcast(atm_provides_lightning_out, mpicom) |
There was a problem hiding this comment.
Please replace this with
ESMF_VMBroadcast
you can find usage examples in, for example, shr_drydep_mod.F90
| use shr_sys_mod , only : shr_sys_abort | ||
| use shr_log_mod , only : shr_log_getLogUnit | ||
| use shr_nl_mod , only : shr_nl_find_group_name | ||
| use shr_mpi_mod , only : shr_mpi_bcast |
There was a problem hiding this comment.
We are deprecating shr_mpi_mod, please use ESMF_VMBroadcast instead.
modified: cesm/nuopc_cap_share/shr_lightning_coupling_mod.F90
jedwards4b
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Enables passing prognostic cloud-to-ground lightning flash frequency from CAM to CTSM
Specific notes
Issues Fixed (include github issue #):
ESCOMP/CTSM#1630
ESCOMP/CAM#567
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
b4b
Testing performed
ERC_D_Ln9_Vnuopc.f19_f19_mg17.QPC6.cheyenne_intel.cam-outfrq3s_cosp
SMS_D_Ln9_Vnuopc.f19_f19_mg17.FWma2000climo.cheyenne_intel.cam-outfrq9s
SMS_D_Ln9_Vnuopc_P720x1.ne30pg3_ne30pg3_mg17.FCLTHIST.cheyenne_intel.cam-outfrq9s
SMS_Ln9_Vnuopc.f19_f19.F2000climo.cheyenne_intel.cam-silhs