Make separate instantaneous and non-inst. history tapes #2445
Task list completed / task-list-completed
succeeded
Jan 8, 2025 in 0s
1 / 1 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| If avgflag /= 'I', time_bounds is present and time = mid of time_bounds | Incomplete |
| Some long_name changes | Incomplete |
| Treating avgflag as a tape (not field) trait for 'I' and 'L' tapes | Incomplete |
| Code review suggestion that I should implement in this PR: | |
| #2838 (comment) | Completed |
Code in python/ctsm/crop_calendars/ to handle either instantaneous or non-inst. tapes |
Incomplete |
RXCROPMATURITYINST and RXCROPMATURITYSKIPGENINST SystemTests, to test things when a certain tape is forced to be instantaneous. |
Incomplete |
| The history field lists seem ok in the lnd.log but somehow the 'I' field (SNOW_PERSISTENCE) shows up in h0a. Why? | Incomplete |
| The history field lists seem to include h0, h1, h2, ... in the lnd.log, yet a later comment states that we will get only 1 tape. Why? | Incomplete |
| I have added new write statements but have not tested them. Also, does (1) possibly come in with the call hfields_write? | Incomplete |
| nflds must have the wrong value in line 1001 for ntapes to end up equal to 1. I now think ntapes needs to be dimensioned by maxsplitfiles OR (preferred?) line 1001 may need to say | |
if (any(tape(t)%nflds(:)) > 0) then |
Incomplete |
| As far as I can tell this parameter could be declared private. | Incomplete |
| The 3 public parameters above it get used outside of histFileMod. | Incomplete |
| In the context of this PR, do I need to worry about the corresponding section of code in src/utils/clmfates_interfaceMod.F90 which looks at fincl statements for FATES vars? Follow up. | Incomplete |
Loading