feature #5985 Test Symfony 6.4 compatibility (javiereguiluz)

This PR was merged into the 4.x branch. Discussion ---------- Test Symfony 6.4 compatibility Commits ------- 274c5df Test Symfony 6.4 compatibility
EasyCorp · Oct 27, 2023 · 05fe53c · 05fe53c
2 parents 925e2a0 + 274c5df
commit 05fe53c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -60,7 +60,8 @@ jobs:
             matrix:
                 os: [ubuntu-latest]
                 php_version: ["8.1", "8.2"]
-                symfony_version: ["5.4", "6.0", "6.1", "6.2", "6.3"]
+                symfony_version: ["5.4", "6.0", "6.1", "6.2", "6.3", "6.4.0-beta1"]
+                stability: ["stable"]
                 include:
                     # Latest Symfony version support
                     - os: macos-latest
@@ -80,13 +81,18 @@ jobs:
                     - os: ubuntu-latest
                       php_version: "8.0.2"
                       composer_args: "--prefer-lowest"
-                    # Lowest php version support. Remove when it is dropped
+                    # Lowest PHP version support. Remove when it is dropped
                     - os: ubuntu-latest
                       php_version: "8.0"
                       symfony_version: "5.4"
                     - os: ubuntu-latest
                       php_version: "8.0"
                       symfony_version: "6.0"
+                    # Upcoming Symfony versions
+                    -   os: ubuntu-latest
+                        php_version: "8.1"
+                        symfony_version: "6.4.0-beta1"
+                        stability: "dev"
         runs-on: ${{ matrix.os }}
         steps:
             - uses: actions/checkout@v4
@@ -105,6 +111,10 @@ jobs:
                   composer global config --no-plugins allow-plugins.symfony/flex true
                   composer global require symfony/flex
 
+            - name: Configure Composer stability
+              run: |
+                  composer config minimum-stability ${{ matrix.stability }}
+
             - name: Configure Symfony version for symfony/flex
               if: ${{ matrix.symfony_version }}
               run: composer config extra.symfony.require "${{ matrix.symfony_version }}"

diff --git a/src/Cache/CacheWarmer.php b/src/Cache/CacheWarmer.php
@@ -28,7 +28,7 @@ public function isOptional(): bool
         return false;
     }
 
-    public function warmUp(string $cacheDir): array
+    public function warmUp(string $cacheDir, ?string $buildDir = null): array
     {
         $allRoutes = $this->router->getRouteCollection();
         $dashboardRoutes = [];