Skip to content

Commit

Permalink
bug #6502 Fix version where pretty admin URLs were added (fabpot)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.x branch.

Discussion
----------

Fix version where pretty admin URLs were added

<!--
Thanks for your contribution! If you are proposing a new feature that is complex,
please open an issue first so we can discuss about it.

Note: all your contributions adhere implicitly to the MIT license
-->

Commits
-------

5d4a94b Fix version where pretty admin URLs were added
  • Loading branch information
javiereguiluz committed Nov 4, 2024
2 parents e1025aa + 5d4a94b commit a305b2b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions doc/dashboards.rst
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ Dashboard Route
Pretty Admin URLs
-----------------

.. versionadded:: 4.13.0
.. versionadded:: 4.14.0

The support for pretty admin URLs was introduced in EasyAdmin 4.13.0.
The support for pretty admin URLs was introduced in EasyAdmin 4.14.0.

EasyAdmin backends define concise and predictable route names (e.g. ``admin_product_index``
or ``admin_category_detail``) that generate short and pretty URLs (e.g. ``/admin/product``
Expand Down
2 changes: 1 addition & 1 deletion src/Router/AdminUrlGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ public function generateUrl(): string
if (!$usePrettyUrls && \in_array($routeParameters[EA::CRUD_ACTION] ?? Action::INDEX, Crud::ACTION_NAMES, true)) {
trigger_deprecation(
'easycorp/easyadmin-bundle',
'4.13.0',
'4.14.0',
'Not using pretty admin URLs is deprecated because they will become the only available URLs starting from EasyAdmin 5.0.0. Read the docs to learn how to enable pretty URLs in your application.',
);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baseline-ignore.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
%Since easycorp/easyadmin-bundle 4.13.0: Not using pretty admin URLs is deprecated because they will become the only available URLs starting from EasyAdmin 5.0.0. Read the docs to learn how to enable pretty URLs in your application.%
%Since easycorp/easyadmin-bundle 4.14.0: Not using pretty admin URLs is deprecated because they will become the only available URLs starting from EasyAdmin 5.0.0. Read the docs to learn how to enable pretty URLs in your application.%

0 comments on commit a305b2b

Please sign in to comment.