Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the alignment of form fields in some cases #6003

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

javiereguiluz
Copy link
Collaborator

When using Bootstrap, you must be careful when nesting <div class="row">. We didn't do this correctly in all cases, so the column/fieldsets sometimes didn't span the entire available width.

Before this PR After this PR
Captura de pantalla 2023-11-04 a las 12 29 09 Captura de pantalla 2023-11-04 a las 12 28 45

The trick is to remove the first <div class="row"> that wraps everything. Whenever we need to wrap fields in rows (inside tabs, columns or fieldsets) we already add a row, so we don't need that extra one.

@javiereguiluz javiereguiluz added this to the 4.x milestone Nov 4, 2023
@javiereguiluz javiereguiluz merged commit 4537990 into EasyCorp:4.x Nov 4, 2023
23 checks passed
@javiereguiluz javiereguiluz deleted the fix_alignment branch November 4, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant