Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap 5.3 #6005

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

javiereguiluz
Copy link
Collaborator

Fixes #5951.

@chapterjason
Copy link
Contributor

I found the following things in a project, some might not be related to the update.

  • To enable the bootstrap dark color mode, we need to set the data-bs-theme="dark" for the body element here.
    document.body.classList.remove('ea-light-scheme', 'ea-dark-scheme');
    document.body.classList.add('light' === resolvedColorScheme ? 'ea-light-scheme' : 'ea-dark-scheme');
    localStorage.setItem(this.#colorSchemeLocalStorageKey, colorScheme);
    document.body.style.colorScheme = resolvedColorScheme;
  • Noticed a missing border radius in the trix editor, which causes the overlap of an inner element over the border.
    Screenshot 2023-11-04 at 5 57 29 PM
    Can be fixed by
    trix-toolbar {
      border-top-left-radius: var(--border-radius);
      border-top-right-radius: var(--border-radius);
    }
    
    in file
  • The checkbox doesn't get updated by clicking on the text, but the checkbox changed and opened the inputs. (Looks like this works only with label tag and the for attribute)
  • And the space between the filter inputs is missing.
    Screenshot 2023-11-04 at 6 01 28 PM
  • Also here I noticed a missing border-radius. (The dialog and the dropdown)
    Screenshot 2023-11-04 at 6 03 38 PM

@javiereguiluz
Copy link
Collaborator Author

@chapterjason thanks for your great review 🙇

I fixed all the issues that you pointed (and you are right, some of those issues happened before the update to Bootstrap 5.3).

The only pending thing is:

"The checkbox doesn't get updated by clicking on the text, but the checkbox changed and opened the inputs. (Looks like this works only with label tag and the for attribute)"

I think that the current behavior is "correct" ... you click on the label but that doesn't check the checkbox ... only opens/closes the filter. If you select any option or type anything or click on anything inside the filter, then the filter it's checked automatically. Thanks.

@javiereguiluz javiereguiluz merged commit 510945d into EasyCorp:4.x Nov 7, 2023
@javiereguiluz javiereguiluz deleted the fix_5951 branch November 10, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap Update v5.3.x
2 participants