Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) (POC) Replace Webpack Encore by AssetMapper #6027

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Collaborator

In this PR I'm removing all Sass features used in our styles to just use plain CSS. This will simplify the move to AssetMapper.

However, before continuing, I have a question to @weaverryan: is AssetMapper usable inside a Symfony bundle?

I've read https://symfony.com/doc/current/frontend/asset_mapper.html ... but "nothing" works:

  • I can't run any importmap:* command because this is not an application with a Symfony console
  • Because of this, I need to "manage" the importmap.php manually. This is just impossible.
  • I can't install bundles like symfonycasts/sass-bundle because this is not a Symfony application
  • The asset() function doesn't output versioned assets. Don't know if there's some wiring missing somewhere because this is a bundle not an application
  • ...

Thanks!

@javiereguiluz javiereguiluz added this to the 4.x milestone Nov 18, 2023
@pfpro
Copy link
Contributor

pfpro commented Nov 30, 2023

This looks like a larger mission, I wish the experts every success

@javiereguiluz
Copy link
Collaborator Author

Sorry but I must close this as "won't fix". I'll wait until a bundle similar in size to EasyAdmin does this transition so we can learn from them. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants