(WIP) (POC) Replace Webpack Encore by AssetMapper #6027
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm removing all Sass features used in our styles to just use plain CSS. This will simplify the move to AssetMapper.
However, before continuing, I have a question to @weaverryan: is AssetMapper usable inside a Symfony bundle?
I've read https://symfony.com/doc/current/frontend/asset_mapper.html ... but "nothing" works:
importmap:*
command because this is not an application with a Symfony consoleimportmap.php
manually. This is just impossible.symfonycasts/sass-bundle
because this is not a Symfony applicationasset()
function doesn't output versioned assets. Don't know if there's some wiring missing somewhere because this is a bundle not an applicationThanks!