Add FileField for Files. #6587
Open
Add FileField for Files. #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even if the ImageField is not really suitable for other type of field, you can override the image constraint on the ImageField like this if you still want to upload something else: ImageField::new(...)
->setFileConstraints(new Assert\File(['extensions' => 'pdf']))But I agree a new |
|
Overriding alone is not sufficient, as it will cause other issues in the core code as far as I remember, since I've tried that before if I am not mistaken... :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are constraint issues when attempting to upload a PDF file trough the only "Upload" field there is right now:
ImageField. As stated in this task, it might be valuable to have a middle-class (FileField) that is just extended by theImageField.