Added documentation on JavaScript events #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/javascript-events-documentation
branch
from
f196322 to
b8ce3e1
Compare
4 tasks
|
@rimi-itk kudos for the work done here to document JavaScript events. This is very much valued! 🙇 While merging I did some changes, but they were tweaks and minor changes, so I kept most of your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at adding the missing JavaScripts events documentation (cf. #5922).
I've added a general overview of all JavaScript events on the Events page and details on collection events on the Collection Field page. Any suggestions on other or better ways to organize the event documentation are welcome.
I've tried to document the additional information, if any, available in the event, i.e. the event's
detailproperty value, but I'm not sure if I've done it in the best way possible. Any suggestions for improvements are welcome.