Fix for issue #6519 (Pretty URLs in tests)

[FoxCie]

When using pretty URLs in tests, the AdminUrlGenerator fails to provide the pretty URLs because it checks the use of pretty URLs through the context, which is null when doing requests from tests. This fixes this behaviour by checking the use of pretty URLs directly from the UrlGenerator (Router), which is what is done by the context anyway.

Tests have been adapted to use pretty URLs.

[javiereguiluz]

@FoxCie I'm not sure about these proposed changes.

Currently, we have separate tests for ugly URLs and pretty URLs. See

EasyAdminBundle/.github/workflows/ci.yaml

Lines 146 to 161 in c4d72d4

	- name: Run tests
	continue-on-error: ${{ matrix.stability == 'dev' || matrix.symfony_version == '7.2' }}
	env:
	SYMFONY_DEPRECATIONS_HELPER: "max[total]=999999&ignoreFile=./tests/baseline-ignore.txt"
	run: |
	./vendor/bin/simple-phpunit --exclude-group pretty_urls
	- name: Run Pretty URLs tests
	# Symfony 5.4 version doesn't include the #[Route] attribute needed to run these tests (it only includes the @Route annotation)
	if: ${{ matrix.symfony_version != '5.4' && matrix.composer_args != '--prefer-lowest' }}
	continue-on-error: ${{ matrix.stability == 'dev' || matrix.symfony_version == '7.2' }}
	env:
	USE_PRETTY_URLS: "1"
	SYMFONY_DEPRECATIONS_HELPER: "max[total]=999999&ignoreFile=./tests/baseline-ignore.txt"
	run: |
	./vendor/bin/simple-phpunit tests/Controller/PrettyUrls/PrettyUrlsControllerTest.php

I prefer to have those two test suites separate because mixing pretty URLs with the existing tests that used the traditional ugly URLs is a mess in a my opinion. I'd prefer to keep both separated and then updated all tests to use pretty URLs only in the 5.x branch, which I hope to start soon.

[FoxCie]

Hello @javiereguiluz

I reverted the changes to the tests, and added one in the PrettyUrlControllerTest to show that the AdminUrlGenerator does not behave well in tests when using pretty urls prior to this patch. This is not related to any controller, but since tests are invoked with this class only I added it there.

[javiereguiluz]

Thanks a lot for fixing this bug, providing new tests ... and for your patience and the extra effort during the review process. This is merged now!