Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing Screen (With data mockup) #30

Merged
merged 5 commits into from
Dec 12, 2019
Merged

Listing Screen (With data mockup) #30

merged 5 commits into from
Dec 12, 2019

Conversation

ielijose
Copy link
Collaborator

@ielijose ielijose commented Dec 8, 2019 •
edited
Loading

What's new?

  • Added Listing Screen with styled components.

Visual aids

@ielijose
Fix Build
7ca0821 
gradlew chmod

Regenerate android folder

APP_HOME

test move android folder

test

test

move android folder test

Move files to root
@ielijose
Search Screen & Categories
4758b13
@ielijose ielijose added the need code review Something that need code review of other person label Dec 8, 2019
@cvivieca
Copy link

cvivieca commented Dec 8, 2019

¿Ese issue #2 no lo estaba trabajando @lewandy ?

@cvivieca cvivieca self-requested a review December 8, 2019 18:22
@ielijose ielijose force-pushed the feature/listing-screen branch from f6e82a5 to 3a9157b Compare December 9, 2019 14:04
@umartinez22
Copy link
Collaborator

¿Ese issue #2 no lo estaba trabajando @lewandy ?

Alparecer hubo un cambio de asignacion.

umartinez22
umartinez22 approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@umartinez22 umartinez22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Probado en android y ios.

@cvivieca cvivieca merged commit 9228e36 into master Dec 12, 2019
@frangel02 frangel02 deleted the feature/listing-screen branch February 3, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umartinez22 umartinez22 umartinez22 approved these changes

@cvivieca cvivieca Awaiting requested review from cvivieca

Assignees

@ielijose ielijose

Labels
need code review Something that need code review of other person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ielijose @cvivieca @umartinez22