Raw body support for application/ld+json and application/activity+json #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR Why it is closed now? |
|
I found it causes some trouble with preexisting handlers in some cases. For example: misskey-dev/misskey@04075ee I think this should be handled in a better way (or should state that it breaks some compatibility) |
|
I re-opened it but put it in draft state |
The best approach would be to accept a new user's config to set the content type. Please, add some tests too |
|
Done! Could you review this patch set? @Eomm |
perillamint
force-pushed
the
fix/json-subtype
branch
from
58e9628 to
b7027f7
Compare
Eomm
reviewed
Nov 16, 2023
Eomm
approved these changes
Nov 16, 2023
renovate bot
referenced
this pull request
in redwoodjs/redwood
Nov 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) | [`4.2.2` -> `4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Eomm/fastify-raw-body (fastify-raw-body)</summary> ### [`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0) [Compare Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0) #### What's Changed - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/53](https://togithub.com/Eomm/fastify-raw-body/pull/53) - chore(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/56](https://togithub.com/Eomm/fastify-raw-body/pull/56) - chore(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/58](https://togithub.com/Eomm/fastify-raw-body/pull/58) - Raw body support for application/ld+json and application/activity+json by [@​perillamint](https://togithub.com/perillamint) in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) #### New Contributors - [@​perillamint](https://togithub.com/perillamint) made their first contribution in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) **Full Changelog**: Eomm/fastify-raw-body@v4.2.2...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/redwood
Nov 29, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) | [`4.2.2` -> `4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Eomm/fastify-raw-body (fastify-raw-body)</summary> ### [`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0) [Compare Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0) #### What's Changed - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/53](https://togithub.com/Eomm/fastify-raw-body/pull/53) - chore(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/56](https://togithub.com/Eomm/fastify-raw-body/pull/56) - chore(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/58](https://togithub.com/Eomm/fastify-raw-body/pull/58) - Raw body support for application/ld+json and application/activity+json by [@​perillamint](https://togithub.com/perillamint) in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) #### New Contributors - [@​perillamint](https://togithub.com/perillamint) made their first contribution in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) **Full Changelog**: Eomm/fastify-raw-body@v4.2.2...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel
referenced
this pull request
in specfy/specfy
Nov 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify-raw-body](https://togithub.com/Eomm/fastify-raw-body) | [`4.2.2` -> `4.3.0`](https://renovatebot.com/diffs/npm/fastify-raw-body/4.2.2/4.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Eomm/fastify-raw-body (fastify-raw-body)</summary> ### [`v4.3.0`](https://togithub.com/Eomm/fastify-raw-body/releases/tag/v4.3.0) [Compare Source](https://togithub.com/Eomm/fastify-raw-body/compare/v4.2.2...v4.3.0) #### What's Changed - chore(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/53](https://togithub.com/Eomm/fastify-raw-body/pull/53) - chore(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/56](https://togithub.com/Eomm/fastify-raw-body/pull/56) - chore(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Eomm/fastify-raw-body/pull/58](https://togithub.com/Eomm/fastify-raw-body/pull/58) - Raw body support for application/ld+json and application/activity+json by [@​perillamint](https://togithub.com/perillamint) in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) #### New Contributors - [@​perillamint](https://togithub.com/perillamint) made their first contribution in [https://github.com/Eomm/fastify-raw-body/pull/59](https://togithub.com/Eomm/fastify-raw-body/pull/59) **Full Changelog**: Eomm/fastify-raw-body@v4.2.2...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements raw body support for
application/ld+jsonandapplication/activity+json