Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_move_change_financial_account: Migration to 16.0 #49

Draft
wants to merge 9 commits into
base: 16.0
Choose a base branch
from

Conversation

kaynnan
Copy link
Contributor

@kaynnan kaynnan commented May 3, 2023

@kaynnan kaynnan force-pushed the 16.0-mig-account_move_change_financial_account branch from cd4ad07 to ed7f06e Compare May 3, 2023 17:58
@kaynnan kaynnan marked this pull request as draft May 3, 2023 17:58
@kaynnan kaynnan force-pushed the 16.0-mig-account_move_change_financial_account branch from ed7f06e to 00b44e5 Compare May 3, 2023 18:04
@kaynnan kaynnan marked this pull request as ready for review May 3, 2023 18:09
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (16.0@2ea1fd5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             16.0       #49   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         6           
  Lines           ?        73           
  Branches        ?        12           
========================================
  Hits            ?        73           
  Misses          ?         0           
  Partials        ?         0           

@kaynnan kaynnan marked this pull request as draft May 4, 2023 08:38
@marcelsavegnago
Copy link
Contributor

@kaynnan esta PR está pronta para revisão ?

@kaynnan kaynnan marked this pull request as ready for review May 8, 2023 12:36
@kaynnan
Copy link
Contributor Author

kaynnan commented May 8, 2023

@kaynnan esta PR está pronta para revisão ?

Parcialmente, estou em duvida sobre o inherit o qual tive que incluir na class AccountAccountFinancialRules, sem o mail.thread o addons não permite o manuseamento correto (ocorre erro, o qual ressalta na mensagem a ausência do mail.thread no account.account.financial.rules), aguardo o retorno sobre o inherit do mail.thread no model "account.account.financial.rules"

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Sep 10, 2023
@marcelsavegnago marcelsavegnago marked this pull request as draft October 9, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants