Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Empty reports left for approval when all expenses are moved to different reports and Instant Submit is enabled #54787

Open
1 of 8 tasks
m-natarajan opened this issue Jan 3, 2025 · 20 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar @puneetlath
Slack conversation (hyperlinked to channel name): expense

Action Performed:

  1. Enable Instant Submit.
  2. Submit a report with a pending Expensify card transaction.
  3. Remove the pending transaction by either:
  • The transaction not clearing.
  • The transaction merging with a SmartScanned receipt on another report.

Expected Result:

When the last transaction is removed from a report, the report should be automatically deleted so long as there aren't any user comments on it. If there are user comments, the report should be changed to a chat report. This ensures that we maintain any relevant context and that approvers are not left with empty reports requiring approval.

Actual Result:

The report remains in the approval queue, empty and requiring action from the approver.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (3)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021876502378955345300
  • Upwork Job ID: 1876502378955345300
  • Last Price Increase: 2025-01-14
Issue OwnerCurrent Issue Owner: @waterim
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 3, 2025
Copy link

melvin-bot bot commented Jan 3, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Jan 7, 2025
@melvin-bot melvin-bot bot changed the title Empty Reports Left for Approval When Instant Submit is Enabled [$250] Empty Reports Left for Approval When Instant Submit is Enabled Jan 7, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021876502378955345300

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 7, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@alexpensify
Copy link
Contributor

We are waiting for proposals here

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Jan 7, 2025
@garrettmknight
Copy link
Contributor

Btw, I think this is going to require some BE work.

@melvin-bot melvin-bot bot added the Overdue label Jan 9, 2025
@JmillsExpensify
Copy link

Yeah agreed. Btw, I've been able to reproduce this one, so I'm going to remove the label. Maybe we highlight this as a hotpick?

@JmillsExpensify JmillsExpensify removed the Needs Reproduction Reproducible steps needed label Jan 9, 2025
@rushatgabhane
Copy link
Member

waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2025
@garrettmknight garrettmknight changed the title [$250] Empty Reports Left for Approval When Instant Submit is Enabled [$250] Empty Reports Left for approval when all expenses are rejected and Instant Submit is enabled Jan 10, 2025
@garrettmknight garrettmknight changed the title [$250] Empty Reports Left for approval when all expenses are rejected and Instant Submit is enabled [$250] Empty reports left for approval when all expenses are moved to different reports and Instant Submit is enabled Jan 10, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

@alexpensify, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 14, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 15, 2025

@alexpensify, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 17, 2025

@alexpensify @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 17, 2025

@alexpensify, @rushatgabhane Still overdue 6 days?! Let's take care of this!

@garrettmknight
Copy link
Contributor

@waterim Did I see you comment you wanted to help on this one? 🙏

@waterim
Copy link
Contributor

waterim commented Jan 17, 2025

Hello, yes, Im Artem from Callstack and would like to help with this issue!

@melvin-bot melvin-bot bot added Overdue and removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Jan 20, 2025
@alexpensify
Copy link
Contributor

Alright, I've assigned @waterim. Thanks for helping here!

Copy link

melvin-bot bot commented Jan 21, 2025

@alexpensify, @rushatgabhane, @waterim Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

@waterim please keep us posted when you have an update. Thanks!

Copy link

melvin-bot bot commented Jan 23, 2025

@alexpensify, @rushatgabhane, @waterim Eep! 4 days overdue now. Issues have feelings too...

@waterim
Copy link
Contributor

waterim commented Jan 25, 2025

Hello, Im working on this issue, was not able to fix this issue yet, but will have more time next week to finish!

@melvin-bot melvin-bot bot removed the Overdue label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

7 participants