[NoQA] Use op read to get data from 1Password #55577

mountiny · 2025-01-21T22:23:12Z

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/461026
PROPOSAL:

MOBILE-EXPENSIFY:13370

Tests

run the Adhoc build for hybrid to check if the op command is successful

Test run: https://github.com/Expensify/App/actions/runs/12897488048/job/35962734444

The op step was a success but the build failed, not a blocker for this I think

Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-21T22:23:17Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-01-21T22:23:54Z

https://github.com/Expensify/App/actions/runs/12897008031

ishpaul777 · 2025-01-21T22:30:02Z

Does this requires a c+ ? @mountiny

mountiny · 2025-01-21T23:35:02Z

Here was a successful run that got us past the op check but the build failed for some other reason I think (not clear to me from the logs) https://github.com/Expensify/App/actions/runs/12897488048/job/35962734444

However, this syntax follows how we read the files in other workflow so should be good

@AndrewGable could you please review? Thanks!

AndrewGable · 2025-01-21T23:49:20Z

It got past the op step but I am not sure it downloaded it or it actually worked because it's complaining about the thing you are trying to download from op 🤔

Error: No profile for team '368M544MTT' matching '(OldApp) AppStore: Notification Service' found: Xcode couldn't find any provisioning profiles matching '368M544MTT/(OldApp) AppStore: Notification Service'. Install the profile (by dragging and dropping it onto Xcode's dock item) or select a different one in the Signing & Capabilities tab of the target editor. (in target 'NotificationServiceExtension' from project 'Expensify')

mountiny · 2025-01-21T23:54:48Z

Damn it, I skimmed over it but looked for wrong words, yeah that seems like it was either not downloaded correctly or they are not saved in the right place for the build to work right

mountiny · 2025-01-21T23:56:20Z

The path seems correct

App/fastlane/Fastfile

Lines 426 to 436 in 5cd60fe

    
           install_provisioning_profile( 
        
             path: "./OldApp_AdHoc.mobileprovision" 
        
           ) 
        
           install_provisioning_profile( 
        
             path: "./OldApp_AdHoc_Share_Extension.mobileprovision" 
        
           ) 
        
           install_provisioning_profile( 
        
             path: "./OldApp_AdHoc_Notification_Service.mobileprovision" 
        
           )

mountiny · 2025-01-22T00:03:42Z

Not sure why the status is marked as invalid

mountiny · 2025-01-22T13:56:07Z

I have created new AppIDs for the adhoc as they were missing and regenerated the adhoc profiles using those appIDs. New run here. Added those details here https://github.com/Expensify/Expensify/issues/463473

https://github.com/Expensify/App/actions/runs/12909732814

…-updateHybridAppBuild2

Julesssss · 2025-01-22T18:56:28Z

Hey @mountiny I'm trying to catch up with this thread and the fixes you made today. Did you manage to retry with this mentioned fix here?

I will merge these changes to #55577 to test

mountiny · 2025-01-22T20:04:55Z

Continuing in the thread

…-updateHybridAppBuild2

github-actions · 2025-01-24T21:00:11Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

* main: (433 commits) Update redirects.csv Update and rename Change-or-add-email-address.md to Managing-Primary-and-Secondary-Logins-in-Expensify.md lint fix type update webpack configuration to use minified pdf.worker file adding check if FS is initialized before trying to shut it down lint failed add tests Use different numbers Update the isCustom param type and add more tests Update the custom feed method Update Mobile-Expensify to 9.0.89-5 Update version to 9.0.89-5 adding new mock method Update Mobile-Expensify to 9.0.89-4 Update version to 9.0.89-4 Update redirects.csv Update Mobile-Expensify to 9.0.89-3 Update version to 9.0.89-3 make includeSelfDM param conditional ... # Conflicts: # Mobile-Expensify

github-actions · 2025-01-24T22:18:19Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-24T22:54:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55577/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55577/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

mountiny self-assigned this Jan 21, 2025

mountiny requested a review from a team as a code owner January 21, 2025 22:23

melvin-bot bot requested review from ishpaul777 and removed request for a team January 21, 2025 22:23

mountiny removed the request for review from ishpaul777 January 21, 2025 23:23

Use different way to read the files from op

5cd60fe

mountiny force-pushed the vit-updateHybridAppBuild branch from baf86ae to 5cd60fe Compare January 21, 2025 23:33

mountiny changed the title ~~Use op read op to get docs from 1p~~ [NoQA] Use op read op to get docs from 1p Jan 21, 2025

mountiny requested a review from AndrewGable January 21, 2025 23:34

mountiny changed the title ~~[NoQA] Use op read op to get docs from 1p~~ [NoQA] Use op read to get data from 1Password Jan 22, 2025

mountiny added 2 commits January 22, 2025 15:16

Merge branch 'main' into vit-updateHybridAppBuild2

4345509

Use process to get the right env

f90c137

mountiny mentioned this pull request Jan 22, 2025

[No QA] Hybrid App adhoc builds follow ups #55061

Merged

49 tasks

mountiny and others added 2 commits January 22, 2025 16:46

Merge main

aed9155

Do not skip build jobs if no OD PR is mentioned

7125704

mountiny mentioned this pull request Jan 22, 2025

[HOLD - replaced by #55577] Do not skip build jobs if no OD PR is mentioned #55615

Open

50 tasks

Merge branch 'jnowakow/do-not-skip-adhoc-builds-if-no-od-pr' into vit…

c20e8d1

…-updateHybridAppBuild2

Update the adhoc profile names

73ba692

Use different token

55fb363

mountiny and others added 7 commits January 23, 2025 15:05

Merge branch 'jnowakow/do-not-skip-adhoc-builds-if-no-od-pr' into vit…

70d6438

…-updateHybridAppBuild2

Fetch PR ref before checkout

183834f

update the fetch

9f338e9

Use adhoc scheme

a8b29a3

Read op files

d1c5067

Merge branch 'jnowakow/do-not-skip-adhoc-builds-if-no-od-pr' into vit…

5f3d7c7

…-updateHybridAppBuild2

update Fastlane, correctly set adhoc type

72a73ab

Julesssss mentioned this pull request Jan 24, 2025

Do not skip build jobs if no OD PR is mentioned #55751

Closed

50 tasks

Julesssss added the Ready To Build label Jan 24, 2025

This comment was marked as resolved.

Sign in to view

Expensify deleted a comment from github-actions bot Jan 24, 2025

This comment has been minimized.

Sign in to view

Julesssss mentioned this pull request Jan 24, 2025

Enable HybridApp test builds in App repo #51636

Open

Julesssss self-assigned this Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Use op read to get data from 1Password #55577

[NoQA] Use op read to get data from 1Password #55577

mountiny commented Jan 21, 2025 •

edited by Julesssss

Loading

melvin-bot bot commented Jan 21, 2025

mountiny commented Jan 21, 2025

ishpaul777 commented Jan 21, 2025 •

edited

Loading

mountiny commented Jan 21, 2025 •

edited

Loading

AndrewGable commented Jan 21, 2025 •

edited

Loading

mountiny commented Jan 21, 2025

mountiny commented Jan 21, 2025

mountiny commented Jan 22, 2025 •

edited

Loading

mountiny commented Jan 22, 2025

Julesssss commented Jan 22, 2025

mountiny commented Jan 22, 2025

This comment was marked as resolved.

github-actions bot commented Jan 24, 2025

This comment has been minimized.

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

[NoQA] Use op read to get data from 1Password #55577

Are you sure you want to change the base?

[NoQA] Use op read to get data from 1Password #55577

Conversation

mountiny commented Jan 21, 2025 • edited by Julesssss Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 21, 2025

mountiny commented Jan 21, 2025

ishpaul777 commented Jan 21, 2025 • edited Loading

mountiny commented Jan 21, 2025 • edited Loading

AndrewGable commented Jan 21, 2025 • edited Loading

mountiny commented Jan 21, 2025

mountiny commented Jan 21, 2025

mountiny commented Jan 22, 2025 • edited Loading

mountiny commented Jan 22, 2025

Julesssss commented Jan 22, 2025

mountiny commented Jan 22, 2025

This comment was marked as resolved.

github-actions bot commented Jan 24, 2025

This comment has been minimized.

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

mountiny commented Jan 21, 2025 •

edited by Julesssss

Loading

ishpaul777 commented Jan 21, 2025 •

edited

Loading

mountiny commented Jan 21, 2025 •

edited

Loading

AndrewGable commented Jan 21, 2025 •

edited

Loading

mountiny commented Jan 22, 2025 •

edited

Loading