Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing concepts via secondary category #188

Closed
wants to merge 4 commits into from
Closed

Conversation

patrickkwang
Copy link
Contributor

@patrickkwang patrickkwang commented Oct 5, 2021

Fixes #181.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #188 (e1e1f2e) into master (9905697) will decrease coverage by 0.55%.
The diff coverage is n/a.

❗ Current head e1e1f2e differs from pull request most recent head 6401681. Consider uploading reports for the commit 6401681 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   81.95%   81.39%   -0.56%     
==========================================
  Files          15       15              
  Lines        1236     1172      -64     
==========================================
- Hits         1013      954      -59     
+ Misses        223      218       -5     
Impacted Files Coverage Δ
icees_api/features/knowledgegraph.py 85.94% <ø> (-0.23%) ⬇️
icees_api/handlers.py 77.56% <0.00%> (-2.75%) ⬇️
icees_api/trapi.py 90.00% <0.00%> (-0.63%) ⬇️
icees_api/app.py 92.77% <0.00%> (-0.09%) ⬇️
icees_api/features/mappings.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56010cb...6401681. Read the comment docs.

@patrickkwang patrickkwang requested a review from davefol October 7, 2021 13:49
@hyi
Copy link
Collaborator

hyi commented Mar 8, 2023

This PR does not apply any more due to removal of knowledgegraph.py as part of moving to ICEES KG cleanup, so closing the PR.

@hyi hyi closed this Mar 8, 2023
@hyi hyi deleted the second-cat branch March 8, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be more flexible with qnode categories
3 participants