Pin score in highest division to rating #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackYps
force-pushed
the
score-calculation
branch
from
d688257 to
f51e8ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #69 +/- ##
===========================================
- Coverage 96.66% 96.66% -0.01%
===========================================
Files 12 12
Lines 510 509 -1
===========================================
- Hits 493 492 -1
Misses 17 17 ☔ View full report in Codecov by Sentry. |
Askaholic
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
high rated players want to have some sort of leaderboard and they treat rating as the authority of skill measurement.
The current code doesn't really ensure that people are ranked by their rating.
This change pins the score to the underlying rating in the highest division (grandmaster) only. If the underlying rating changes enough, the score will change aswell.