Skip to content

v1.3.4 - Handle any error in broadcast
Compare
Choose a tag to compare
@Askaholic Askaholic released this 06 Feb 08:39
· 260 commits to develop since this release
v1.3.4
9993b7b
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Summary

Turns out there are some exceptions that are caused by a lost or unavailable connection that do not inherit from ConnectionError. For instance OSError: [Errno 113] No route to host and TimeoutError: [Errno 110] Connection timed out. Since errors during broadcast don't really matter (if we can't reach the target they just don't get the message, no big deal), we just ignore all exceptions raised from drain. We also rewrite do_report_dirties so that even if an exception were to be raised during one broadcast, the rest of the broadcasts, and more importantly ended game removal, will still happen.

Pull Requests

  • Fix exception handling (#528)
Assets 2
Loading