🚚 RBC Output directory upgrades Pt. 11 #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnizzedy
changed the title
Co-authored-by: Taylor Salo <salot@pennmedicine.upenn.edu>
Ref https://docs.google.com/document/d/16CvBwVMAs0IMhdoKmlmcm3W8254dQmNARo-7HhE-lJU Co-authored-by: Taylor Salo <salot@pennmedicine.upenn.edu>
Co-authored-by: Steve Giavasis <sgiava77@gmail.com>
shnizzedy
force-pushed
the
outputs/1.8.5
branch
from
91be1de to
6fc6607
Compare
8 tasks
|
Do we want to update these C-PAC/CPAC/resources/cpac_outputs.tsv Lines 117 to 130 in cc05874 desc-{whatever}_quality in this PR even though they're not part of RBC's outputs?
|
Co-authored-by: Steve Giavasis <sgiava77@gmail.com>
shnizzedy
force-pushed
the
outputs/1.8.5
branch
from
9ce079a to
7daf78f
Compare
|
Reverting to draft to address
|
Ref #1849 (comment) Co-authored-by: Greg Kiar <gkiar@users.noreply.github.com>
shnizzedy
commented
Nov 29, 2022
shnizzedy
added
engine
sgiavasis
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #1808 by @shnizzedy
Description
res-[A-Za-z0-9]*output entities to use actual resolution from sidecardesc-preproc_boldinstead ofdesc-brain_bold{what-ever}-qctoto desc-{whatEver}_qualityatlas-name_desc-disambigintoatlas-nameDisambigfor derivativespreproctoheadScreenshots
benchmark-FNIRT@ 6fc6607expectedOututs.ymltree outputbenchmark-FNIRT@ 56b58c4expectedOututs.ymlChecklist
Update index.md).developbranch of the repository.Developer Certificate of Origin
Developer Certificate of Origin