-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slurp mod version from json to avoid issues in IDE #113
Conversation
See FabricMC/fabric-loader#457 Signed-off-by: liach <liach@users.noreply.github.com>
I don't think this is suitable for the example mod - other mod properties are set in gradle.properties, it shouldn't be inverted for this one special thing. If auto-run of processResources is really so generally needed, then adding things like Idea's extension so that processResources being autorun will already be configured, or a possible loom change to make it so. |
Some properties are set in |
For @dexman545, I don't think it's quite easy to set the run configurations' resource classpath to the output of processresources. If we can add a correct dependency on process resources for loom, it's good too, but doing it correctly is a bit hard. |
I'm not sure about what loom can do, but it is worth mentioning as a possibility. Yes, you modify both files - that does not change the fact that |
I don't buy into this gradle.properties argument, it obviously breaks in-dev use and alters the product in ways that are too extensive for a build system - a version is no build ID. Neither does it make a different to edit one file or another, having to change both is rare. Running gradle in the IDE is not a solution, it turns instant run (esp. Eclipse) into waiting for gradle to start+finish and complicates the project setup. |
Is this blocked until the loader version override is available or can this be merged already? |
I added a thing to loom to do this nicely: FabricMC/fabric-loom@2c464cd Will need to wait for a stable build of 0.10 |
What about 0.7? |
What do you mean? 0.10 is the version that is being developed atm and will be made stable once its ready. 0.7 was completed long ago. |
I should update the site, 0.9 is recommended for everyone, you can still use it build mods for java 8 (see fabric API's 1.16 branch) |
This is already fixed by loom, right? |
See FabricMC/fabric-loader#457
Signed-off-by: liach liach@users.noreply.github.com