slightly optimize contribution stats using sets

package.json

@@ -22,7 +22,7 @@
 		"@types/cors": "^2.8.17",
 		"@types/express": "^5.0.0",
 		"@types/multer": "^1.4.12",
-		"@types/node": "^22.8.4",
+		"@types/node": "^22.9.0",
 		"@types/response-time": "^2.3.8",
 		"@types/statuses": "^2.0.5",
 		"@types/swagger-ui-express": "^4.1.7",
@@ -45,7 +45,7 @@
 		"body-parser": "^1.20.3",
 		"cloudflare": "^3.5.0",
 		"cors": "^2.8.5",
-		"discord-api-types": "^0.37.102",
+		"discord-api-types": "^0.37.103",
 		"dotenv": "^16.4.5",
 		"express": "^4.21.1",
 		"firestorm-db": "^1.13.0",

src/v2/service/contribution.service.ts

@@ -25,10 +25,9 @@ export default class ContributionService {
 
 	async getStats(): Promise<ContributionStats> {
 		const cs = await this.getRaw();
-		let total_authors = 0;
-		let total_contributions = 0;
 
-		const authors = {};
+		// set ensures unique values much more quickly than a check object/array iteration
+		const authors = new Set();
 
 		let total_last_week = 0;
 		let total_last_month = 0;
@@ -41,18 +40,11 @@ export default class ContributionService {
 		const aggregate: PackRecord = {} as PackRecord;
 
 		Object.values(cs).forEach((cur) => {
-			total_contributions += 1;
+			cur.authors.forEach((a) => authors.add(a));
 
-			cur.authors.forEach((a) => {
-				if (!authors[a]) {
-					authors[a] = true;
-					total_authors++;
-				}
-			});
-
-			const { pack, date: timestamp } = cur;
+			const { pack, date } = cur;
 			//! Group data by the start of date if time dont coincide
-			const start_of_day = startOfDay(timestamp).getTime();
+			const start_of_day = startOfDay(date).getTime();
 
 			aggregate[pack] ||= {};
 			aggregate[pack][start_of_day] ||= {
@@ -61,9 +53,9 @@ export default class ContributionService {
 			};
 			aggregate[pack][start_of_day].count++;
 
-			if (timestamp >= last_week) total_last_week += 1;
-			if (timestamp >= last_month) total_last_month += 1;
-			if (timestamp >= last_day) total_last_day += 1;
+			if (date >= last_week) total_last_week += 1;
+			if (date >= last_month) total_last_month += 1;
+			if (date >= last_day) total_last_day += 1;
 		});
 
 		const finalActivity = {} as PackData;
@@ -79,8 +71,8 @@ export default class ContributionService {
 		});
 
 		return {
-			total_authors,
-			total_contributions,
+			total_authors: authors.size,
+			total_contributions: Object.keys(cs).length,
 			total_last_day,
 			total_last_week,
 			total_last_month,

src/v2/tools/utils.ts

@@ -1,20 +1,20 @@
 export const WEEK_LENGTH = 604800000;
 export function lastWeek() {
-	return new Date(+new Date() - WEEK_LENGTH);
+	return new Date(new Date().getTime() - WEEK_LENGTH);
 }
 
 export const MONTH_LENGTH = 2629800000;
 export function lastMonth() {
-	return new Date(+new Date() - MONTH_LENGTH);
+	return new Date(new Date().getTime() - MONTH_LENGTH);
+}
+
+export const DAY_LENGTH = 86400000;
+export function lastDay() {
+	return new Date(new Date().getTime() - DAY_LENGTH);
 }
 
 export function startOfDay(date: Date | number) {
 	const result = new Date(date);
 	result.setHours(0, 0, 0, 0);
 	return result;
 }
-
-export const DAY_LENGTH = 86400000;
-export function lastDay() {
-	return new Date(+new Date() - DAY_LENGTH);
-}