Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OZ][L-04] Treasury Fees Can Be Locked in the SFC #102

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Nov 26, 2024

This PR adds collection of failed trasury fees and option to claim them later.

@Mike-CZ Mike-CZ requested review from thaarok and jmpike November 26, 2024 11:30
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow Checks-Effects-Interactions Pattern

contracts/sfc/SFC.sol Outdated Show resolved Hide resolved
@Mike-CZ Mike-CZ requested a review from thaarok November 27, 2024 09:00
thaarok
thaarok previously approved these changes Nov 27, 2024
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mike-CZ Mike-CZ changed the title Add collection of failed treasury fees [OZ][L-04] Treasury Fees Can Be Locked in the SFC Dec 13, 2024
@Mike-CZ Mike-CZ changed the base branch from mike/ownable_constants_manager to main December 16, 2024 14:59
@Mike-CZ Mike-CZ dismissed thaarok’s stale review December 16, 2024 14:59

The base branch was changed.

@Mike-CZ Mike-CZ merged commit 70b03aa into main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants