-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage gaps into upgradeable contracts #103
Conversation
What is the purpose of this?
I don't see how is this going to help in the top-level contract...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throughout the codebase, there are several contracts that are inherited by upgradeable contracts that do not include a storage gap
There are not. The mentioned contracts are top-level, they are never inherited by other contracts in production, only in few unit-test scenarios like UnitTestSFC/etc.
There is no reason for these gaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As confirmed by auditors - since these contracts are NOT parents of other contracts, gaps or namespaced storage in these contracts will not bring any advantage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already in prod, whatever...
This PR adds storage gaps into upgradeable contracts to avoid post-deployment upgradeability issues.