Code

Quantstamp findings fixes#122

Code

Open

Mike-CZ wants to merge 12 commits intomainFantom-foundation/opera-sfc:mainfrom mike/qs-fixesFantom-foundation/opera-sfc:mike/qs-fixesCopy head branch name to clipboard

+282-134

Commits

Commits on Dec 14, 2024

• [SFC-2] CEI Pattern Not Enforced in undelegate()

  Mike-CZ

  committed
  50e4f62

  Copy full SHA for 50e4f62

Commits on Dec 15, 2024

• [SFC-4] Risk of Front-Running when Deploying the System

  Mike-CZ

  committed
  7308149

  Copy full SHA for 7308149

• [SFC-5] Some Important Updates of the System Do Not Emit Events

  Mike-CZ

  committed
  f7aeb4b

  Copy full SHA for f7aeb4b

• [SFC-6] Missing Interface Check in SFC ._notifyStakeSubscriber()

  Mike-CZ

  committed
  e554675

  Copy full SHA for e554675

• [SFC-9] Withdrawn Event May Reflect Incorrect Amount Due to Penalty

  Mike-CZ

  committed
  c4b3a15

  Copy full SHA for c4b3a15

• [SFC-11] Unclear Behavior for Edge Cases in Reward Calculation

  Mike-CZ

  committed
  157d51d

  Copy full SHA for 157d51d

• [S-1] Documentation Issues

  Mike-CZ

  committed
  5fb2393

  Copy full SHA for 5fb2393

• [S-2] Code Conciseness

  Mike-CZ

  committed
  6f9b6d9

  Copy full SHA for 6f9b6d9

• [S-3] Gas Optimization

  Mike-CZ

  committed
  6c59a16

  Copy full SHA for 6c59a16

• [S-4] SFC Contract Does Not Implement the ISFC Interface

  Mike-CZ

  committed
  ec80b7f

  Copy full SHA for ec80b7f

• [S-6] Unnecessary Upgradeable Feature in ConstantsManager

  Mike-CZ

  committed
  25ad4c0

  Copy full SHA for 25ad4c0

• [S-7] Missing Validations

  Mike-CZ

  committed
  8ef035c

  Copy full SHA for 8ef035c