Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1286

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

Tanmay692004
Copy link
Contributor

@Tanmay692004 Tanmay692004 commented Jan 2, 2025

Clicking on Logo opens the website in new tab instead of opening the image itself

Description

The logo has been updated to be clickable and opens the Gymnasium website in a new tab when clicked. This change improves navigation by allowing users to visit the website without leaving the current page.

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Before

before

After

after

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

logo opens website in new tab
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looks helpful, if you want to add this to the other farama-foundation projects they would be welcome

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 13d5ecc into Farama-Foundation:main Jan 3, 2025
13 checks passed
@Tanmay692004
Copy link
Contributor Author

Tanmay692004 commented Jan 3, 2025 via email

@Tanmay692004
Copy link
Contributor Author

Tanmay692004 commented Jan 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants